linux-kernel - Re: [PATCH] hw breakpoint: Fix possible memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330338785.11248.49.camel@twins>
Date:	Mon, 27 Feb 2012 11:33:05 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Namhyung Kim <namhyung.kim@....com>
Cc:	Ingo Molnar <mingo@...e.hu>, Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] hw breakpoint: Fix possible memory leak

On Mon, 2012-02-27 at 12:02 +0900, Namhyung Kim wrote:
> If kzalloc() for TYPE_DATA failed on a given cpu, previous chunk
> will be leaked. Fix it.

so why not fix the error loop? wouldn't putting that err_cpu == cpu
break after the kfree sort it?

> Signed-off-by: Namhyung Kim <namhyung.kim@....com>
> ---
>  kernel/events/hw_breakpoint.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index b0309f76d777..58298b0d0e92 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -645,8 +645,12 @@ int __init init_hw_breakpoint(void)
>  			task_bp_pinned = &per_cpu(nr_task_bp_pinned[i], cpu);
>  			*task_bp_pinned = kzalloc(sizeof(int) * nr_slots[i],
>  						  GFP_KERNEL);
> -			if (!*task_bp_pinned)
> +			if (!*task_bp_pinned) {
> +				while (--i >= 0)
> +					kfree(per_cpu(nr_task_bp_pinned[i],
> +						      cpu));
>  				goto err_alloc;
> +			}
>  		}
>  	}
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/