linux-kernel - RE: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0D3EFCAF29FAA54FB91286E54DF1085C2304850551@MTKMBS30.mediatek.inc>
Date:	Mon, 27 Feb 2012 19:57:59 +0800
From:	Meng Zhang (张萌) <Meng.Zhang@...iatek.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>,
	"smurf@...rf.noris.de" <smurf@...rf.noris.de>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

Dear both,

Sorry I'm still a rookie in kernel patching, and should I commit this change by myself or let owner (hi, Matthias) do it?

Thanks~

BR.
Meng Zhang

-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov@...sta.com] 
Sent: Monday, February 27, 2012 7:07 PM
To: Meng Zhang (张萌)
Cc: smurf@...rf.noris.de; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

Hello.

On 27-02-2012 8:11, Meng Zhang (张萌) wrote:

> 1. To declare the product IDs in option.c 2. Please pull from
> 	git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>     to get these changes

    This patch is not yet there. :-)

> Signed-off-by: Meng Zhang<meng.zhang@...iatek.com>
> ----------------------------------------------------------------------
> -----------------

    This line is not needed. If you want a sperator, use --- instead.

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c 
> index b54afce..7069f9d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -484,6 +484,9 @@ static void option_instat_callback(struct urb *urb);
>   #define LG_VENDOR_ID                           0x1004
>   #define LG_PRODUCT_L02C                                0x618f
>
> +/* MediaTek products */
> +#define MEDIATEK_VENDOR_ID                     0x0e8d
> +
>   /* some devices interfaces need special handling due to a number of reasons */
>   enum option_blacklist_reason {
>                  OPTION_BLACKLIST_NONE = 0, @@ -1198,6 +1201,10 @@ 
> static const struct usb_device_id option_ids[] = {
>          { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) },
>          { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 0xff, 0xff, 0xff) },
>          { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo 
> L-02C modem */
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x00, 0x00) },
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x02, 0x01) },
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x00, 0x00) },
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x02, 0x01) },        /* MediaTek MT6276M modem&  app port */

    All tabs in the patch were converted to spaces.

WBR, Sergei