linux-kernel - Re: [PATCH] tracing: don't select FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330349831.25686.188.camel@gandalf.stny.rr.com>
Date:	Mon, 27 Feb 2012 08:37:11 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Gerlando Falauto <gerlando.falauto@...mile.com>
Cc:	holger.brunck@...mile.com,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: don't select FRAME_POINTER on PPC

On Mon, 2012-02-27 at 09:08 +0100, Gerlando Falauto wrote:
> On PowerPC, FUNCTION_TRACER selects FRAME_POINTER, even
> though the architecture does not support it.
> 
> This causes the following warning:
> warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)
> 
> So remove the warning by adding the extra condition
> "if !PPC" to FUNCTION_TRACER for FRAME_POINTER selection

I'll queue it up for 3.4, if that's fine with you.

Thanks,

-- Steve

> 
> Signed-off-by: Gerlando Falauto <gerlando.falauto@...mile.com>
> ---
>  kernel/trace/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 2ad39e5..fbdec2e 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -141,7 +141,7 @@ if FTRACE
>  config FUNCTION_TRACER
>  	bool "Kernel Function Tracer"
>  	depends on HAVE_FUNCTION_TRACER
> -	select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
> +	select FRAME_POINTER if !ARM_UNWIND && !PPC && !S390 && !MICROBLAZE
>  	select KALLSYMS
>  	select GENERIC_TRACER
>  	select CONTEXT_SWITCH_TRACER


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/