linux-kernel - Re: [PATCH] parisc: dont unconditionally override CROSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F4BB315.6060501@bell.net>
Date:	Mon, 27 Feb 2012 11:45:09 -0500
From:	John David Anglin <dave.anglin@...l.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	JBottomley@...allels.com, jejb@...isc-linux.org, kyle@...artin.ca,
	deller@....de, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for
 64 bit.

On 2/27/2012 11:28 AM, Paul Gortmaker wrote:
> On 12-02-27 10:14 AM, John David Anglin wrote:
>> >  On 2/26/2012 6:26 PM, Paul Gortmaker wrote:
>>> >>  Using the 64 bit toolchains from kernel.org[1], one finds that
>>> >>  you can't build the a500_defconfig, because the Makefile will
>>> >>  stomp whatever value you have in your env. for CROSS_COMPILE.
>>> >>
>>> >>  This shows up since the kernel.org toolchains for parisc-64
>>> >>  do not have the "-gnu" prefix, and so you run into it always
>>> >>  saying hppa64-linux-gnu-gcc not found, regardless of the fact
>>> >>  you've not got "-gnu" put anywhere into CROSS_COMPILE.
>>> >>
>>> >>  [1]ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>>> >>
>>> >>  Signed-off-by: Paul Gortmaker<paul.gortmaker@...driver.com>
>>> >>
>>> >>  diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>>> >>  index 55cca1d..cefff6d 100644
>>> >>  --- a/arch/parisc/Makefile
>>> >>  +++ b/arch/parisc/Makefile
>>> >>  @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
>>> >>     UTS_MACHINE	:= parisc64
>>> >>     CHECKFLAGS	+= -D__LP64__=1 -m64
>>> >>     WIDTH		:= 64
>>> >>  -CROSS_COMPILE	:= hppa64-linux-gnu-
>>> >>  +ifndef CROSS_COMPILE
>>> >>  + CROSS_COMPILE	:= hppa64-linux-gnu-
>>> >>  +endif
>>> >>     else # 32-bit
>>> >>     WIDTH		:=
>>> >>     endif
>> >  This change breaks native builds.  So, I assume CROSS_COMPILE must be
>> >  previously defined.
> You lost me here.  As in a native 32bit env. doing a build for the
> 64 bit case is setting CROSS_COMPILE?
>
Yes, native hppa is 32 bit .  Building a 64-bit kernel with CONFIG_64BIT 
causes the
setting of CROSS_COMPILE and the selection of hppa64-linux-gnu-gcc, etc.
If CROSS_COMPILE wasn't previously defined, your change wouldn't have have
affected the 64-bit build.

Dave

-- 
John David Anglin    dave.anglin@...l.net

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/