linux-kernel - Re: "whitespace coding style cleanup" broke coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330361549.9942.7.camel@joe2Laptop>
Date:	Mon, 27 Feb 2012 08:52:29 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Hansjoerg Lipp <hjlipp@....de>,
	Tilman Schmidt <tilman@...p.cc>,
	gigaset307x-common@...ts.sourceforge.net,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: "whitespace coding style cleanup" broke coding style

On Mon, 2012-02-27 at 09:59 +0100, Jiri Slaby wrote:
> commit 475be4d85a274d0961593db41cf85689db1d583c
> Author: Joe Perches <joe@...ches.com>
> Date:   Sun Feb 19 19:52:38 2012 -0800
> 
>      isdn: whitespace coding style cleanup
> 
>      isdn source code uses a not-current coding style.
> ...
>      Done with emacs and some scripts and some typing.
> ...
> --- a/drivers/isdn/gigaset/interface.c
> +++ b/drivers/isdn/gigaset/interface.c
> ...
> @@ -680,9 +680,9 @@ void gigaset_if_initdriver(struct gigaset_driver 
> *drv, const
>   char *procname,
>                  goto enomem;
> 
>          tty->magic =            TTY_DRIVER_MAGIC,
> -       tty->type =             TTY_DRIVER_TYPE_SERIAL,
> -       tty->subtype =          SERIAL_TYPE_NORMAL,
> -       tty->flags =            TTY_DRIVER_REAL_RAW | 
> TTY_DRIVER_DYNAMIC_DEV;
> +               tty->type =             TTY_DRIVER_TYPE_SERIAL,
> +               tty->subtype =          SERIAL_TYPE_NORMAL,
> +               tty->flags =            TTY_DRIVER_REAL_RAW | 
> TTY_DRIVER_DYNAMIC_DEV;
> 
> Hmm, please, fix your scripts or emacs!

Hi Jiri.

I'm not fixing emacs.

Notice that the code improperly uses commas and
not semicolons for line terminations like the
lines immediately above and below it.

btw:  Your copy/paste lost the tab indents.

The emacs pass was not perfect, nor was it
intended to be perfect.  There are _way_
too many coding style defects in isdn for
that.

It was a first pass and an overall improvement.

"It's quite a bit more like what passes
for the current kernel coding style though."

> Through which tree did this get in?

net-next

> thanks,

I'm working on improving the logging style
in isdn and will submit more patches soonish.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/