| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAErSpo4PMzuPdCZvbYFiQRGjGuMg+KYk0ZxJH0xr-n6AfqBAnA@mail.gmail.com>
Date: Mon, 27 Feb 2012 10:57:18 -0700
From: Bjorn Helgaas <bhelgaas@...gle.com>
To: Yinghai Lu <yinghai@...nel.org>
Cc: Jesse Barnes <jbarnes@...tuousgeek.org>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] PCI: add generic device into pci_host_bridge struct
On Sun, Feb 26, 2012 at 4:33 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> use that device for pci_root_bus bridge pointer.
>
> With that make code more simple.
>
> Also we can use pci_release_bus_bridge_dev() to release allocated
> pci_host_bridge during removing path.
>
> At last, we can use root bus bridge pointer to get host bridge pointer instead
> of going over host bridge list, so could kill that host bridge list.
>
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>
> ---
> drivers/pci/host-bridge.c | 14 ---------
> drivers/pci/pci.h | 2 -
> drivers/pci/probe.c | 65 ++++++++++++++++++++++++----------------------
> include/linux/pci.h | 4 ++
> 4 files changed, 38 insertions(+), 47 deletions(-)
>
> Index: linux-2.6/drivers/pci/host-bridge.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/host-bridge.c
> +++ linux-2.6/drivers/pci/host-bridge.c
> @@ -9,13 +9,6 @@
>
> #include "pci.h"
>
> -static LIST_HEAD(pci_host_bridges);
> -
> -void add_to_pci_host_bridges(struct pci_host_bridge *bridge)
> -{
> - list_add_tail(&bridge->list, &pci_host_bridges);
> -}
> -
> static struct pci_bus *find_pci_root_bus(struct pci_dev *dev)
> {
> struct pci_bus *bus;
> @@ -33,16 +26,11 @@ static struct pci_bus *find_pci_root_bus
> static struct pci_host_bridge *find_pci_host_bridge(struct pci_dev *dev)
> {
> struct pci_bus *bus = find_pci_root_bus(dev);
> - struct pci_host_bridge *bridge;
>
> if (!bus)
> return NULL;
>
> - list_for_each_entry(bridge, &pci_host_bridges, list)
> - if (bridge->bus == bus)
> - return bridge;
> -
> - return NULL;
> + return to_pci_host_bridge(bus->bridge);
> }
>
> static bool resource_contains(struct resource *res1, struct resource *res2)
> Index: linux-2.6/drivers/pci/pci.h
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci.h
> +++ linux-2.6/drivers/pci/pci.h
> @@ -231,8 +231,6 @@ static inline int pci_ari_enabled(struct
> void pci_reassigndev_resource_alignment(struct pci_dev *dev);
> extern void pci_disable_bridge_window(struct pci_dev *dev);
>
> -void add_to_pci_host_bridges(struct pci_host_bridge *bridge);
> -
> /* Single Root I/O Virtualization */
> struct pci_sriov {
> int pos; /* capability position */
> Index: linux-2.6/drivers/pci/probe.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/probe.c
> +++ linux-2.6/drivers/pci/probe.c
> @@ -421,6 +421,19 @@ static struct pci_bus * pci_alloc_bus(vo
> return b;
> }
>
> +static struct pci_host_bridge *pci_alloc_host_bridge(struct pci_bus *b)
> +{
> + struct pci_host_bridge *bridge;
> +
> + bridge = kzalloc(sizeof(*bridge), GFP_KERNEL);
> + if (bridge) {
> + INIT_LIST_HEAD(&bridge->windows);
> + bridge->bus = b;
> + }
> +
> + return bridge;
> +}
> +
> static unsigned char pcix_bus_speed[] = {
> PCI_SPEED_UNKNOWN, /* 0 */
> PCI_SPEED_66MHz_PCIX, /* 1 */
> @@ -1121,7 +1134,13 @@ int pci_cfg_space_size(struct pci_dev *d
>
> static void pci_release_bus_bridge_dev(struct device *dev)
> {
> - kfree(dev);
> + struct pci_host_bridge *bridge = to_pci_host_bridge(dev);
> +
> + /* TODO: need to free window->res */
> +
> + pci_free_resource_list(&bridge->windows);
> +
> + kfree(bridge);
> }
>
> struct pci_dev *alloc_pci_dev(void)
> @@ -1570,28 +1589,19 @@ struct pci_bus *pci_create_root_bus(stru
> int error;
> struct pci_host_bridge *bridge;
> struct pci_bus *b, *b2;
> - struct device *dev;
> struct pci_host_bridge_window *window, *n;
> struct resource *res;
> resource_size_t offset;
> char bus_addr[64];
> char *fmt;
>
> - bridge = kzalloc(sizeof(*bridge), GFP_KERNEL);
> - if (!bridge)
> - return NULL;
>
> b = pci_alloc_bus();
> if (!b)
> - goto err_bus;
> -
> - dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> - if (!dev)
> - goto err_dev;
> + return NULL;
>
> b->sysdata = sysdata;
> b->ops = ops;
> -
> b2 = pci_find_bus(pci_domain_nr(b), bus);
> if (b2) {
> /* If we already got to this bus through a different bridge, ignore it */
> @@ -1599,13 +1609,17 @@ struct pci_bus *pci_create_root_bus(stru
> goto err_out;
> }
>
> - dev->parent = parent;
> - dev->release = pci_release_bus_bridge_dev;
> - dev_set_name(dev, "pci%04x:%02x", pci_domain_nr(b), bus);
> - error = device_register(dev);
> + bridge = pci_alloc_host_bridge(b);
> + if (!bridge)
> + goto err_out;
> +
> + bridge->dev.parent = parent;
> + bridge->dev.release = pci_release_bus_bridge_dev;
> + dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(b), bus);
> + error = device_register(&bridge->dev);
> if (error)
> - goto dev_reg_err;
> - b->bridge = get_device(dev);
> + goto bridge_dev_reg_err;
> + b->bridge = get_device(&bridge->dev);
> device_enable_async_suspend(b->bridge);
> pci_set_bus_of_node(b);
>
> @@ -1624,9 +1638,6 @@ struct pci_bus *pci_create_root_bus(stru
>
> b->number = b->secondary = bus;
>
> - bridge->bus = b;
> - INIT_LIST_HEAD(&bridge->windows);
> -
> if (parent)
> dev_info(parent, "PCI host bridge to bus %s\n", dev_name(&b->dev));
> else
> @@ -1652,25 +1663,17 @@ struct pci_bus *pci_create_root_bus(stru
> }
>
> down_write(&pci_bus_sem);
> - add_to_pci_host_bridges(bridge);
> list_add_tail(&b->node, &pci_root_buses);
> up_write(&pci_bus_sem);
>
> return b;
>
> class_dev_reg_err:
> - device_unregister(dev);
> -dev_reg_err:
> - down_write(&pci_bus_sem);
> - list_del(&bridge->list);
> - list_del(&b->node);
> - up_write(&pci_bus_sem);
> + device_unregister(&bridge->dev);
> +bridge_dev_reg_err:
> + kfree(bridge);
> err_out:
> - kfree(dev);
> -err_dev:
> kfree(b);
> -err_bus:
> - kfree(bridge);
> return NULL;
> }
>
> Index: linux-2.6/include/linux/pci.h
> ===================================================================
> --- linux-2.6.orig/include/linux/pci.h
> +++ linux-2.6/include/linux/pci.h
> @@ -375,11 +375,13 @@ struct pci_host_bridge_window {
> };
>
> struct pci_host_bridge {
> - struct list_head list;
> + struct device dev;
> struct pci_bus *bus; /* root bus */
> struct list_head windows; /* pci_host_bridge_windows */
> };
This doesn't feel right to me. You're allocating a new struct device
here, but the arch likely already has one. In fact, I think we even
passed it in to pci_create_root_bus().
On x86, we already have an ACPI device for the host bridge, and now
we'll have a second one. (Actually a *third* one, because PNPACPI
also has one, but that's a long-standing problem.)
> +#define to_pci_host_bridge(n) container_of(n, struct pci_host_bridge, dev)
> +
> /*
> * The first PCI_BRIDGE_RESOURCE_NUM PCI bus resources (those that correspond
> * to P2P or CardBus bridge windows) go in a table. Additional ones (for
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists