linux-kernel - Re: [PATCH 66/73] ext2: Split ext2_add_entry() from ext2_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B5DCCBD9-F032-44E1-8368-146137487B83@dilger.ca>
Date:	Sun, 26 Feb 2012 20:30:34 -0700
From:	Andreas Dilger <adilger@...ger.ca>
To:	"Ted Ts'o" <tytso@....edu>
Cc:	David Howells <dhowells@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"viro@...IV.linux.org.uk" <viro@...IV.linux.org.uk>,
	"valerie.aurora@...il.com" <valerie.aurora@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jan Kara <jack@...e.cz>,
	"linux-ext4@...nel.org" <linux-ext4@...nel.org>
Subject: Re: [PATCH 66/73] ext2: Split ext2_add_entry() from ext2_add_link() [ver #2]

On 2012-02-26, at 17:04, Ted Ts'o <tytso@....edu> wrote:
> On Tue, Feb 21, 2012 at 06:05:46PM +0000, David Howells wrote:
>> From: Valerie Aurora <vaurora@...hat.com>
>> 
>> Allow future code to use the guts of ext2_add_link().
>> 
>> Original-author: Valerie Aurora <vaurora@...hat.com>
>> Signed-off-by: David Howells <dhowells@...hat.com>
>> Cc: Jan Kara <jack@...e.cz>
>> Cc: linux-ext4@...nel.org
> 
> I'd suggest folding this in with the following patch (67/73).  It's
> not clear from this patch why renaming ext2_add_link to
> ext2_add_entry() makes sense and then adding a new ext2_add_link()
> which calls ext_add_entry().   It doesn't seem to clarify much....

Also, why is this being done in ext2, when it should only be done in ext4?

Fedora is already using ext4 for ext2- and ext3-formatted filesystems, to allow us to finally deprecate and then delete both of those trees and their ongoing duplicate maintenance.  Adding new features to ext2 doesn't help that goal at all.

Cheers, Andreas--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/