linux-kernel - Re: [RFC PATCH 18/22] ext3: add support for .read_iter and .write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F4C04EE.7080306@zabbo.net>
Date:	Mon, 27 Feb 2012 17:34:22 -0500
From:	Zach Brown <zab@...bo.net>
To:	Dave Kleikamp <dave.kleikamp@...cle.com>
CC:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH 18/22] ext3: add support for .read_iter and .write_iter


>   drivers/block/loop.c |   55 ++++++++++++++++++-
>   fs/ext3/file.c       |    2 +
>   fs/ext3/inode.c      |  149 ++++++++++++++++++++++++++++++++++----------------
>   include/linux/loop.h |    1 +
>   4 files changed, 160 insertions(+), 47 deletions(-)

It looks like the patch that teaches loop to use the kernel aio
interface got combined with the patch that adds the _bvec entry points
to ext3.

> +	if (file->f_op->write_iter&&  file->f_op->read_iter) {
> +		file->f_flags |= O_DIRECT;
> +		lo_flags |= LO_FLAGS_USE_AIO;
> +	}

This manual setting of f_flags still looks very fishy to me.  I remember
finding that pattern somewhere else but that's not very comforting :).

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/