linux-kernel - Re: [RFC PATCH 03/22] fuse: convert fuse to use iov_iter_copy_[to|from]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871upfb9yf.fsf@tucsk.pomaz.szeredi.hu>
Date:	Tue, 28 Feb 2012 10:09:44 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Dave Kleikamp <dave.kleikamp@...cle.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Zach Brown <zab@...bo.net>, fuse-devel@...ts.sourceforge.net
Subject: Re: [RFC PATCH 03/22] fuse: convert fuse to use iov_iter_copy_[to|from]_user

Dave Kleikamp <dave.kleikamp@...cle.com> writes:

> A future patch hides the internals of struct iov_iter, so fuse should
> be using the supported interface.
>
> Signed-off-by: Dave Kleikamp <dave.kleikamp@...cle.com>

Acked-by: Miklos Szeredi <mszeredi@...e.cz>

Thanks,
Miklos

> Cc: Miklos Szeredi <miklos@...redi.hu>
> Cc: fuse-devel@...ts.sourceforge.net
> ---
>  fs/fuse/file.c |   29 ++++++++---------------------
>  1 file changed, 8 insertions(+), 21 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 4a199fd..877cee0 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1582,30 +1582,17 @@ static int fuse_ioctl_copy_user(struct page **pages, struct iovec *iov,
>  	while (iov_iter_count(&ii)) {
>  		struct page *page = pages[page_idx++];
>  		size_t todo = min_t(size_t, PAGE_SIZE, iov_iter_count(&ii));
> -		void *kaddr;
> +		size_t left;
>  
> -		kaddr = kmap(page);
> -
> -		while (todo) {
> -			char __user *uaddr = ii.iov->iov_base + ii.iov_offset;
> -			size_t iov_len = ii.iov->iov_len - ii.iov_offset;
> -			size_t copy = min(todo, iov_len);
> -			size_t left;
> -
> -			if (!to_user)
> -				left = copy_from_user(kaddr, uaddr, copy);
> -			else
> -				left = copy_to_user(uaddr, kaddr, copy);
> -
> -			if (unlikely(left))
> -				return -EFAULT;
> +		if (!to_user)
> +			left = iov_iter_copy_from_user(page, &ii, 0, todo);
> +		else
> +			left = iov_iter_copy_to_user(page, &ii, 0, todo);
>  
> -			iov_iter_advance(&ii, copy);
> -			todo -= copy;
> -			kaddr += copy;
> -		}
> +		if (unlikely(left))
> +			return -EFAULT;
>  
> -		kunmap(page);
> +		iov_iter_advance(&ii, todo);
>  	}
>  
>  	return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/