linux-kernel - Re: [PATCH] cpumask: fix lg_lock/br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120228112422.GC11324@alboin.amr.corp.intel.com>
Date:	Tue, 28 Feb 2012 03:24:22 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Nick Piggin <npiggin@...nel.dk>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] cpumask: fix lg_lock/br_lock.

On Mon, Feb 27, 2012 at 03:53:38PM -0800, Andrew Morton wrote:
> On Tue, 28 Feb 2012 09:52:30 +1030
> Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> > Use a cpumask_var_t instead of cpumask_t.  We're doing plenty of
> > allocations here anyway, so it's not really an issue, and it sets a
> > good example.
> > 
> > (cpumask_t is obsolescent, as are the cpus_* functions).
> 
> Congratulations to yourself and Andi:

Well the only way to avoid that problem is to merge it ASAP.

The patch -- like most code movement patches -- is totally unsuitable for 
keeping around for months in trees.

Usually I found the best way to do merges with code movement patches
is to edit the patches itself if possible.

Maybe some day we'll get patch like tools that can deal with this stuff
better.

Rusty: you should probably have cocci rules for this stuff, not manual
patches.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/