linux-kernel - Re: [PATCH] trace: Fix build breakage without CONFIG_PERF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330440751.25686.216.camel@gandalf.stny.rr.com>
Date:	Tue, 28 Feb 2012 09:52:31 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: Fix build breakage without CONFIG_PERF_EVENTS

On Tue, 2012-02-28 at 15:43 +0100, Jiri Olsa wrote:
> On Tue, Feb 28, 2012 at 02:03:35PM +0000, Mark Brown wrote:
> > On Tue, Feb 28, 2012 at 09:02:09AM -0500, Steven Rostedt wrote:
> > > On Tue, 2012-02-28 at 13:37 +0000, Mark Brown wrote:
> > 
> > > > ARM.  If it was not possible to switch off PERF_EVENTS it shouldn't be a
> > > > config option in the code as this is just creating complexity and
> > > > potential breakage.
> > 
> > > It is possible to switch off PERF_EVENTS, just not on x86 :-/
> > 
> > Well, if you insist on using these restricted architectures :P
> 
> reproduced ;) looking for fix..
> 
> jirka
> 
> 
> [jolsa@m tip]$ make   ARCH=arm CROSS_COMPILE=armv5tel-redhat-linux-gnueabi- uImage 
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
> make[1]: `include/generated/mach-types.h' is up to date.
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CC      kernel/trace/trace_export.o
> In file included from kernel/trace/trace_export.c:197:
> kernel/trace/trace_entries.h:58: error: ‘perf_ftrace_event_register’
> undeclared here (not in a function)
> make[2]: *** [kernel/trace/trace_export.o] Error 1
> make[1]: *** [kernel/trace] Error 2
> make: *** [kernel] Error 2

Hmm, I'm surprised my cross build test didn't catch this.

Crap, I think I only ran the defconfig tests, and not the test that also
enables tracing.

I'll update my config to do both automatically.

Thanks!

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/