linux-kernel - Re: [PATCH trivial next 9/9] gadget: Use vsprintf extention %pf with builtin_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120228193906.GA891@legolas.emea.dhcp.ti.com>
Date:	Tue, 28 Feb 2012 21:39:07 +0200
From:	Felipe Balbi <balbi@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	Felipe Balbi <balbi@...com>, Jiri Kosina <trivial@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH trivial next 9/9] gadget: Use vsprintf extention %pf with
 builtin_return_address

On Tue, Feb 28, 2012 at 10:49:38AM -0800, Joe Perches wrote:
> Emit the function name not the address when possible.
> 
> builtin_return_address() gives an address.  When building
> a kernel with CONFIG_KALLSYMS, emit the actual function
> name not the address.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/usb/gadget/u_serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> index 6597a68..a553bee 100644
> --- a/drivers/usb/gadget/u_serial.c
> +++ b/drivers/usb/gadget/u_serial.c
> @@ -920,7 +920,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
>  	unsigned long	flags;
>  	int		status;
>  
> -	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %p\n",
> +	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
>  		port->port_num, tty, ch, __builtin_return_address(0));
>  
>  	spin_lock_irqsave(&port->port_lock, flags);
> -- 
> 1.7.8.111.gad25c.dirty
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)