lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Feb 2012 16:11:31 -0800 From: Kevin Hilman <khilman@...com> To: Tarun Kanti DebBarma <tarun.kanti@...com> Cc: <linux-omap@...r.kernel.org>, <grant.likely@...retlab.ca>, <tony@...mide.com>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 6/6] gpio/omap: fix _set_gpio_irqenable implementation Tarun Kanti DebBarma <tarun.kanti@...com> writes: > This function should be capable of both enabling and disabling interrupts > based upon the *enable* parameter. Right now the function only enables > the interrupt and *enable* is not used at all. So add the interrupt > disable capability also using the parameter. > > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@...com> Hmm, interesting. This means that the IRQ mask/unmask stuff is not actually doing anything since it's always leaving the IRQ enabled. Curious that we haven't seen side effects of that. Maybe since the trigger type is none, the interrupts won't fire. In any case, this is a good fix. Kevin > --- > drivers/gpio/gpio-omap.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 67535c8..acc71a0 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -473,7 +473,10 @@ static void _disable_gpio_irqbank(struct gpio_bank *bank, int gpio_mask) > > static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int enable) > { > - _enable_gpio_irqbank(bank, GPIO_BIT(bank, gpio)); > + if (enable) > + _enable_gpio_irqbank(bank, GPIO_BIT(bank, gpio)); > + else > + _disable_gpio_irqbank(bank, GPIO_BIT(bank, gpio)); > } > > /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists