| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120228011100.GA18378@kroah.com> Date: Mon, 27 Feb 2012 17:11:00 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: Alan Cox <alan@...rguk.ukuu.org.uk> Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org Subject: Re: [RFC PATCH] vt:tackle kbd_table On Mon, Feb 27, 2012 at 04:10:23PM +0000, Alan Cox wrote: > This could do with some extra eyes and double checking. With this one out of > the day we can start to make a dent in the console locking logic and thus > eventually into tty_lock(). > > From: Alan Cox <alan@...ux.intel.com> > > Keyboard struct lifetime is easy, but the locking is not and is completely > ignored by the existing code. Tackle this one head on > > - Make the kbd_table private so we can run down all direct users > - Hoick the relevant ioctl handlers into the keyboard layer > - Lock them with the keyboard lock so they don't change mid keypress > - Add helpers for things like console stop/start so we isolate the poking > around properly > - Tweak the braille console so it still builds The drivers/staging/speakup/main.c code also would need to be tweaked in this same manner, but that's not a big deal. Other than that, at first glance, this looks good, nice job. Care to make the speakup change and resend it so we can try it out in linux-next? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists