linux-kernel - Re: [PATCH 08/73] VFS: Add CL_NO_SHARED flag to clone_mnt()/copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120229065616.GB5030@ram-ThinkPad-T61>
Date:	Wed, 29 Feb 2012 14:56:16 +0800
From:	Ram Pai <linuxram@...ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-fsdevel@...r.kernel.org, viro@...IV.linux.org.uk,
	valerie.aurora@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/73] VFS: Add CL_NO_SHARED flag to
 clone_mnt()/copy_tree() [ver #2]

On Tue, Feb 21, 2012 at 05:58:25PM +0000, David Howells wrote:
> From: Valerie Aurora <vaurora@...hat.com>
> 
> Passing the CL_NO_SHARED flag to clone_mnt() causes the clone to fail
> if the source mnt is shared.
> 
> Original-author: Valerie Aurora <vaurora@...hat.com>
> Signed-off-by: David Howells <dhowells@...hat.com>
> Cc: Ram Pai <linuxram@...ibm.com>

Reviewed-by: Ram Pai <linuxram@...ibm.com>

> ---
> 
>  fs/namespace.c |    3 +++
>  fs/pnode.h     |    1 +
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 35c3b80..f92f574 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -740,6 +740,9 @@ static struct mount *clone_mnt(struct mount *old, struct dentry *root,
>  	struct mount *mnt;
>  	int err;
> 
> +	if ((flag & CL_NO_SHARED) && IS_MNT_SHARED(old))
> +		return ERR_PTR(-EINVAL);
> +
>  	mnt = alloc_vfsmnt(old->mnt_devname);
>  	if (!mnt)
>  		return ERR_PTR(-ENOMEM);
> diff --git a/fs/pnode.h b/fs/pnode.h
> index 65c6097..c7089dd 100644
> --- a/fs/pnode.h
> +++ b/fs/pnode.h
> @@ -22,6 +22,7 @@
>  #define CL_COPY_ALL 		0x04
>  #define CL_MAKE_SHARED 		0x08
>  #define CL_PRIVATE 		0x10
> +#define CL_NO_SHARED 		0x20
> 
>  static inline void set_mnt_shared(struct mount *mnt)
>  {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/