linux-kernel - Re: [PATCH 1/2] OpenRISC: Fix audit_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330501592.2964.1.camel@crucifix>
Date:	Wed, 29 Feb 2012 08:46:32 +0100
From:	Jonas Bonn <jonas@...thpole.se>
To:	Richard Weinberger <richard@....at>
Cc:	arnd@...db.de, linux@...ts.openrisc.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage


Thanks, Richard.  There is, however, already a patch in linux-next that
provides this fix.

/Jonas

On Wed, 2012-02-29 at 01:46 +0100, Richard Weinberger wrote:
> Commit d7e7528 (Audit: push audit success and retcode into arch ptrace.h)
> changed audit_syscall_exit().
> 
> Fixes:
>   CC      arch/openrisc/kernel/ptrace.o
> arch/openrisc/kernel/ptrace.c: In function ‘do_syscall_trace_leave’:
> arch/openrisc/kernel/ptrace.c:206:21: error: macro "audit_syscall_exit" passed 2 arguments, but takes just 1
> arch/openrisc/kernel/ptrace.c:205:3: error: ‘audit_syscall_exit’ undeclared (first use in this function)
> arch/openrisc/kernel/ptrace.c:205:3: note: each undeclared identifier is reported only once for each function it appears in
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  arch/openrisc/kernel/ptrace.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/ptrace.c b/arch/openrisc/kernel/ptrace.c
> index 656b94b..fa381b2 100644
> --- a/arch/openrisc/kernel/ptrace.c
> +++ b/arch/openrisc/kernel/ptrace.c
> @@ -202,8 +202,7 @@ asmlinkage void do_syscall_trace_leave(struct pt_regs *regs)
>  	int step;
>  
>  	if (unlikely(current->audit_context))
> -		audit_syscall_exit(AUDITSC_RESULT(regs->gpr[11]),
> -				   regs->gpr[11]);
> +		audit_syscall_exit(regs);
>  
>  	step = test_thread_flag(TIF_SINGLESTEP);
>  	if (step || test_thread_flag(TIF_SYSCALL_TRACE))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/