linux-kernel - Re: [PATCH] dma: imx-sdma: Add error check on sdma_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120229083845.GU3852@pengutronix.de>
Date:	Wed, 29 Feb 2012 09:38:45 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Fabio Estevam <festevam@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel@...gutronix.de,
	shawn.guo@...escale.com, vinod.koul@...el.com,
	dan.j.williams@...el.com,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] dma: imx-sdma: Add error check on sdma_get_firmware

On Mon, Feb 20, 2012 at 02:49:50PM -0200, Fabio Estevam wrote:
> Add error check on sdma_get_firmware for the pdata case.
> 
> While at it, distinguish the error message between the pdata and dt cases.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>  drivers/dma/imx-sdma.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index bf736ad..52a4e6a 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1388,7 +1388,11 @@ static int __init sdma_probe(struct platform_device *pdev)
>  		sdma_add_scripts(sdma, pdata->script_addrs);
>  
>  	if (pdata) {
> -		sdma_get_firmware(sdma, pdata->fw_name);
> +		ret = sdma_get_firmware(sdma, pdata->fw_name);
> +		if (ret) {
> +			dev_err(&pdev->dev, "failed to get firmware from pdata\n");
> +			goto err_init;
> +		}

No, you shouldn't bail out here. A failure in sdma_get_firmware only
means that we don't have the RAM scripts, but we can continue with the
ROM scripts and still do useful things in the driver.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/