linux-kernel - Re: [PATCH] mac80211: improve PID rate control mechanism by avoiding rate oscillation problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRGNgV5vmLptT5mFCs02xD_6+SxqO25BA2e67kH6_mcNhi-8w@mail.gmail.com>
Date:	Thu, 1 Mar 2012 00:02:27 +1100
From:	Julian Calaby <julian.calaby@...il.com>
To:	YIN Wei <yinwei168@...il.com>
Cc:	johannes <johannes@...solutions.net>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	mattias.nissler@....de, stefano.brivio@...imi.it
Subject: Re: [PATCH] mac80211: improve PID rate control mechanism by avoiding
 rate oscillation problem

Hi Yin,

One final thing:

On Wed, Feb 29, 2012 at 23:59, Julian Calaby <julian.calaby@...il.com> wrote:
>> @@ -318,22 +578,61 @@ rate_control_pid_rate_init(void *priv, s
>>                        rinfo[i].diff = i * pinfo->norm_offset;
>>        }
>>        for (i = 1; i < sband->n_bitrates; i++) {
>> -               s = false;
>> +               s = 0;
>
> Why are you using integers with a boolean variable?
>
>>                for (j = 0; j < sband->n_bitrates - i; j++)
>>                        if (unlikely(sband->bitrates[rinfo[j].index].bitrate >
>> -                                    sband->bitrates[rinfo[j + 1].index].bitrate)) {
>> +                               sband->bitrates[rinfo[j + 1].index].bitrate)) {

This whitespace change should be dropped.

>>                                tmp = rinfo[j].index;
>>                                rinfo[j].index = rinfo[j + 1].index;
>>                                rinfo[j + 1].index = tmp;
>>                                rinfo[rinfo[j].index].rev_index = j;
>>                                rinfo[rinfo[j + 1].index].rev_index = j + 1;
>> -                               s = true;
>> +                               s = 1;
>>                        }
>>                if (!s)
>>                        break;

In fact, this entire hunk should be dropped.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/