[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4F4E3059.7040004@redhat.com>
Date: Wed, 29 Feb 2012 11:04:09 -0300
From: Mauro Carvalho Chehab <mchehab@...hat.com>
To: Borislav Petkov <bp@...64.org>
CC: Tony Luck <tony.luck@...el.com>, Ingo Molnar <mingo@...e.hu>,
EDAC devel <linux-edac@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH 1/3] mce: Add a msg string to the MCE tracepoint
Em 29-02-2012 10:45, Borislav Petkov escreveu:
> On Wed, Feb 29, 2012 at 09:52:33AM -0300, Mauro Carvalho Chehab wrote:
>
> [snip a bunch of crap I'm tired of correcting again, for the 100th time]
>
>> What I'm saying is that, we should, at least, add 4 fields there, instead of one:
>>
>> - severity
>> - location
>
> I've already explained to you why this format doesn't fit the MCE
> tracepoint - go and read my replies to you again.
No, you didn't. Every time i touch on this point, you just say that it doesn't
fit without giving any explanation why not.
The severity is there, even on your patches, but encoded as string:
+#define PR_EMERG BIT(0)
+#define PR_WARNING BIT(1)
There are, actually, 3 variants, on Intel MCA:
- corrected error;
- uncorrected error (bit 61 of status);
- uncorrected, recoverable error (bit 61 + bit 56 of status).
The location is also there encoded at the MCA. It is specific to the type
of the error, but all errors happen somewhere: a CPU, a BUS, a memory, ...
>> - silkscreen_label
>
> ditto.
ditto: all errors happen somewhere. The silkscreen label is the first
replaceable unit to be replaced by the user, in order to get rid of the
error.
>
>> - error_msg
>
> [ snip more bullshit ]
>
Running away from this discussion won't help at all.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists