linux-kernel - Re: [PATCH 4/8] bcm63xx_enet: use dev_set_mac_address() instead of bcm_enet_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F4E48F0.80805@freebox.fr>
Date:	Wed, 29 Feb 2012 16:49:04 +0100
From:	Florian Fainelli <ffainelli@...ebox.fr>
To:	Danny Kukawka <danny.kukawka@...ect.de>
CC:	"David S. Miller" <davem@...emloft.net>,
	Danny Kukawka <dkukawka@...e.de>,
	Stephen Hemminger <shemminger@...tta.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Jiri Kosina <jkosina@...e.cz>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] bcm63xx_enet: use dev_set_mac_address() instead of
 bcm_enet_set_mac_address()

Le 02/29/12 16:42, Danny Kukawka a écrit :
> Use dev_set_mac_address() instead of bcm_enet_set_mac_address() directly
> to get validation checks for free.
>
> Signed-off-by: Danny Kukawka<danny.kukawka@...ect.de>

Acked-by: Florian Fainelli <ffainelli@...ebox.fr>

> ---
>   drivers/net/ethernet/broadcom/bcm63xx_enet.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index c7ca7ec..28184a8 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -858,7 +858,7 @@ static int bcm_enet_open(struct net_device *dev)
>
>   	/* write device mac address */
>   	memcpy(addr.sa_data, dev->dev_addr, ETH_ALEN);
> -	bcm_enet_set_mac_address(dev,&addr);
> +	dev_set_mac_address(dev,&addr);
>
>   	/* allocate rx dma ring */
>   	size = priv->rx_ring_size * sizeof(struct bcm_enet_desc);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/