linux-kernel - Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOZdJXV69jbbDbJKrLevLxe-2Qqz1wd-g6mBDwecL=r1jJ1jcA@mail.gmail.com>
Date:	Wed, 29 Feb 2012 18:08:49 +0000
From:	Tabi Timur-B04825 <B04825@...escale.com>
To:	Shubhrajyoti Datta <omaplinuxkernel@...il.com>
CC:	Zhao Chenhui-B35336 <B35336@...escale.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Li Yang-R58472 <r58472@...escale.com>
Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep
 sleep

On Wed, Feb 29, 2012 at 7:02 AM, Shubhrajyoti Datta
<omaplinuxkernel@...il.com> wrote:
>
>> +#ifdef CONFIG_PM
>> +       u8 fdr, dfsrr;

> How about having  a structure here ?

Why? He's just adding two variables in an existing structure.  Adding
a nested structure would unnecessarily complicate things.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/