linux-kernel - Re: [PATCH 2/4] power: ab8500-charger: AB8500 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Feb 2012 23:51:21 +0530
From:	Arun Murthy <arunrmurthy.83@...il.com>
To:	Andi <andi.shyti@...il.com>
Cc:	Arun Murthy <arun.murthy@...ricsson.com>, cbou@...l.ru,
	dwmw2@...radead.org, linux-kernel@...r.kernel.org,
	karl.komierowski@...ricsson.com, johan.palsson@...ricsson.com,
	linus.walleij@...aro.org
Subject: Re: [PATCH 2/4] power: ab8500-charger: AB8500 charger driver

>> +       /* Enable main watchdog in OTP */
>> +       ret = abx500_set_register_interruptible(di->dev,
>> +               AB8500_OTP_EMUL, AB8500_OTP_CONF_15, OTP_ENABLE_WD);
>> +       if (ret) {
>> +               dev_err(di->dev, "failed to enable main WD in OTP\n");
>> +               goto out;
>> +       }
>> +
>> +       /* Enable main watchdog */
>> +       ret = abx500_set_register_interruptible(di->dev,
>> +               AB8500_SYS_CTRL2_BLOCK,
>> +               AB8500_MAIN_WDOG_CTRL_REG, MAIN_WDOG_ENA);
>> +       if (ret) {
>> +               dev_err(di->dev, "faile to enable main watchdog\n");
>> +               goto out;
>> +       }
>> +
>> +       /*
>> +        * Due to internal synchronisation, Enable and Kick watchdog bits
>> +        * cannot be enabled in a single write.
>> +        * A minimum delay of 2*32 kHz period (62.5µs) must be inserted
>> +        * between writing Enable then Kick bits.
>> +        */
>> +       udelay(63);
>
> Are you sure about this udelay?
>

Yes, a minimum of 62.5µsec is required. Its also commented just above.

Thanks and Regards,
Arun R Murthy
----------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/