linux-kernel - Re: [PATCH] i2c/imx: fix imx driver to work though signal is pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120229190621.GD30545@pengutronix.de>
Date:	Wed, 29 Feb 2012 20:06:21 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Oskar Schirmer <oskar@...ra.com>
Cc:	Ben Dooks <ben-linux@...ff.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Darius Augulis <augulis.darius@...il.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>
Subject: Re: [PATCH] i2c/imx: fix imx driver to work though signal is pending

On Thu, Feb 23, 2012 at 12:19:11PM +0000, Oskar Schirmer wrote:
> Interrupt a test application for I2C based mc13xxx driven
> touch panel, SIGINT, causes open event file descriptor to be
> closed, which in turn causes I2C activity to mask PMIC local
> interrupts. This eventually ends up in i2c_imx_bus_busy to
> wait for some busy flag to toggle, but while waiting it would
> find a signal pending and break. The final symptom is the
> device is not closed down cleanly and thus not reopenable.
> 
> Do without check for pending signal.
> 
> Signed-off-by: Oskar Schirmer <oskar@...ra.com>

Thanks. Picked to my for-3.4 branch. I'd like to have some more test coverage,
then we can send it back via a stable-release. If you think it should go into
3.3 directly, please let me know.

Oh, and it got acked by Marc Kleine-Budde via phone :)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)