linux-kernel - Re: "whitespace coding style cleanup" broke coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1330543951.21491.15.camel@joe2Laptop>
Date:	Wed, 29 Feb 2012 11:32:31 -0800
From:	Joe Perches <joe@...ches.com>
To:	Armin Schindler <armin@...ware.de>
Cc:	Tilman Schmidt <tilman@...p.cc>, Armin Schindler <mac@...ware.de>,
	Karsten Keil <isdn@...ux-pingi.de>,
	Jiri Slaby <jslaby@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	Hansjoerg Lipp <hjlipp@....de>,
	gigaset307x-common@...ts.sourceforge.net,
	Jiri Slaby <jirislaby@...il.com>,
	David Miller <davem@...emloft.net>
Subject: Re: "whitespace coding style cleanup" broke coding style

On Wed, 2012-02-29 at 09:27 +0100, Armin Schindler wrote:
> On 02/29/2012 12:28 AM, Joe Perches wrote:
> > One of those, Armin Schindler, (cc'd) hasn't
> > signed a single commit in git history.
> True, my last work here was a long time ago.
> I used to maintain the eicon driver, but this driver
> is not just old, it is simply outdated for years and
> I doubt someone will ever use it in newer kernels.
> It just creates work here.

You could remove yourself from MAINTAINERS if you want.

 MAINTAINERS |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5d3ae86..d40a974 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3682,10 +3682,9 @@ F:	include/linux/isdn.h
 F:	include/linux/isdn/
 
 ISDN SUBSYSTEM (Eicon active card driver)
-M:	Armin Schindler <mac@...ware.de>
 L:	isdn4linux@...tserv.isdn4linux.de (subscribers-only)
 W:	http://www.melware.de
-S:	Maintained
+S:	Orphan
 F:	drivers/isdn/hardware/eicon/
 
 IT87 HARDWARE MONITORING DRIVER

> Some time ago I asked (I don't remember who) why
> don't we remove that old driver from the kernel.
> It wasn't done because there is no follow up for the
> kernel. The new drivers out there are maintained,
> but will never be part of the kernel (coding style, etc.).
> I guess the idea was not to remove a driver from the kernel
> when there is no alternative (in kernel).
> Maybe I should bring this up again and ask for a removal of the
> current eicon driver in kernel...

Your choice.

It could be moved to staging as a prelude to removing
it after a few releases.

I did do a rather large drive-by whitespace cleanup
of eicon.  It still compiles.  I've no idea if it
still works though.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/