linux-kernel - Re: [PATCH 12/24] PCI, ia64: Register busn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWBvYZO-D+Z2zwdd0a-bkatF-0YPtmxKP4Se75vccgPrA@mail.gmail.com>
Date:	Tue, 28 Feb 2012 16:12:07 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Tony Luck <tony.luck@...el.com>,
	David Miller <davem@...emloft.net>, x86 <x86@...nel.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, Fenghua Yu <fenghua.yu@...el.com>,
	linux-ia64@...r.kernel.org
Subject: Re: [PATCH 12/24] PCI, ia64: Register busn_res for root buses

On Tue, Feb 28, 2012 at 4:01 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Tue, Feb 28, 2012 at 3:07 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> Cc: Tony Luck <tony.luck@...el.com>
>> Cc: Fenghua Yu <fenghua.yu@...el.com>
>> Cc: linux-ia64@...r.kernel.org
>> ---
>>  arch/ia64/include/asm/pci.h |    1 +
>>  arch/ia64/pci/pci.c         |    5 +++++
>>  2 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/ia64/include/asm/pci.h b/arch/ia64/include/asm/pci.h
>> index b22e5f5..6e54220 100644
>> --- a/arch/ia64/include/asm/pci.h
>> +++ b/arch/ia64/include/asm/pci.h
>> @@ -94,6 +94,7 @@ struct pci_controller {
>>
>>        unsigned int windows;
>>        struct pci_window *window;
>> +       struct resource busn;
>
> Why do you add a new struct resource here?  Can't you just use the one
> passed in from acpi_pci_root_add()?

not quite sure about the life cycle for that object.

>
>>
>>        void *platform_data;
>>  };
>> diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c
>> index d1ce320..b250f0f 100644
>> --- a/arch/ia64/pci/pci.c
>> +++ b/arch/ia64/pci/pci.c
>> @@ -332,6 +332,7 @@ pci_acpi_scan_root(struct acpi_pci_root *root)
>>        struct acpi_device *device = root->device;
>>        int domain = root->segment;
>>        int bus = root->secondary.start;
>> +       int busmax = root->secondary.end;
>>        struct pci_controller *controller;
>>        unsigned int windows = 0;
>>        struct pci_root_info info;
>> @@ -372,6 +373,10 @@ pci_acpi_scan_root(struct acpi_pci_root *root)
>>                acpi_walk_resources(device->handle, METHOD_NAME__CRS,
>>                        add_window, &info);
>>        }
>> +       controller->busn.start = bus;
>> +       controller->busn.end = busmax;
>> +       conttoller->busn.flags = IORESOURCE_BUS;
>
> Typo here - "conttoller" should be "controller".

cool, sharp eyes.

>
>> +       pci_add_resource(&info.resources, &controller->busn);
>>        /*
>>         * See arch/x86/pci/acpi.c.
>>         * The desired pci bus might already be scanned in a quirk. We
>> --
>> 1.7.7
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/