linux-kernel - Re: [PATCH] net: add QCA alx Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120228.212857.797446903975232476.davem@davemloft.net>
Date:	Tue, 28 Feb 2012 21:28:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xiong@....qualcomm.com
Cc:	rodrigue@....qualcomm.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, qca-linux-team@...lcomm.com,
	nic-devel@...lcomm.com, kgiori@....qualcomm.com,
	chris.snook@...il.com, mathieu@....qualcomm.com, bryanh@...cinc.com
Subject: Re: [PATCH] net: add QCA alx Ethernet driver

From: "Huang, Xiong" <xiong@....qualcomm.com>
Date: Wed, 29 Feb 2012 02:19:05 +0000

>      The code related to hardware of atl1c is quite diff with that
> in our hand, every time we take much time to find which part should
> be revised for one bug/issue found on other platform/OSes. the new
> driver make it easy to fix and support new chipset as well.

Broadcom gave the same excuses.  Save yourself some typing.

I already know what you are going to say and claim are the issues.

I've heard it all before, and none of them justify replacing the
existing driver wholesale.  We simply don't operate this way.

Because you guys didn't upstream your driver properly back when
the atl1c hardware first came out and Linux needed a driver,
someone else did.

And we're not removing their driver just because now you guys just
want to come in and take over simply because you're not willing to
collaborate properly and contribute to the existing code like everyone
else on the planet does.

There is no arguing against this, there is no justification, and it
simply will not happen.  I'm sorry you put some must effort into this
but you should have been smart and listened to Luis last year when he
tried to guide you in the right direction.

Listening to Luis would have saved you a lot of wasted engineering.

Maybe you will be smart and listen to him next time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/