linux-kernel - Re: [PATCH v3] checkpatch: Add some --strict coding style checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1330578622.23314.53.camel@joe2Laptop>
Date:	Wed, 29 Feb 2012 21:10:22 -0800
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Kalle Valo <kvalo@....qualcomm.com>,
	Andy Whitcroft <apw@...dowen.org>,
	David Miller <davem@...emloft.net>,
	"John W. Linville" <linville@...driver.com>,
	Ilan Elias <ilane@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Amitkumar Karwar <akarwar@...vell.com>,
	LKML <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	"Bruce W. Allen" <bruce.w.allan@...el.com>,
	Bing Zhao <bzhao@...vell.com>
Subject: Re: [PATCH v3] checkpatch: Add some --strict coding style checks

On Wed, 2012-02-29 at 20:24 -0800, Joe Perches wrote:
> Argument alignment across multiple lines should
> match the open parenthesis.
> 
> Logical continuations should be at the end of
> the previous line, not the start of a new line.
> 
> These are not required by CodingStyle so make the
> tests active only when using --strict.
> 
> Improved_by_examples_from: "Bruce W. Allen" <bruce.w.allan@...el.com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> V3: Use perl 5.10 features
>     Use a runtime check of perl version so $balanced_parens
>     is not used in perl versions that don't support it.
>     Update memset and min_t checks for newer $balanced_parens
>     test.
>     Improve alignment position test.
>     Add message suggesting perl upgrade.

Forgot to mention this stops a hang
in the memset tests.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/