linux-kernel - Re: [PATCH] Trace: initialize variable to clear warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330564158.25686.230.camel@gandalf.stny.rr.com>
Date:	Wed, 29 Feb 2012 20:09:18 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Valdis.Kletnieks@...edu
Cc:	Zhengwang Ruan <ruan.zhengwang@...il.com>, fweisbec@...il.com,
	mingo@...hat.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Trace: initialize variable to clear warning

On Wed, 2012-02-29 at 17:40 -0500, Valdis.Kletnieks@...edu wrote:
> On Tue, 28 Feb 2012 09:16:31 EST, Steven Rostedt said:
> 
> > This is a bug in gcc that's fixed in 4.6 and beyond. I don't want to
> > remove this warning because it will hide a real bug if page2 really does
> > become uninitialized. If 4.6 gives a warning here, then I'll fix it.
> 
> > > -	void *page2;
> > > +	void *uninitialized_var(page2);
> 
> How would you feel about this?
> 
> -	void *page2;
> +	void *page2; /* gcc 4.5 bug causes incorrect "uninitialized" warning */
> 
> or something similar?

/* if you get a warning here, upgrade your gcc to 4.6 */


-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/