linux-kernel - Re: Linux 3.3-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyij_ORw+BE-Sbkt9Y9qcUQSmW_4e-r7p3t0DNA4Sg9pA@mail.gmail.com>
Date:	Thu, 1 Mar 2012 08:22:54 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mark Lord <kernel@...savvy.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 3.3-rc5

On Thu, Mar 1, 2012 at 6:47 AM, Mark Lord <kernel@...savvy.com> wrote:
>
> It's close (after adding a missing left-paren), but not 100% working yet.
> In particular, this command fails to get valid data:  i8kctl bios
>
>    ioctl(3, I8K_BIOS_VERSION, 0xbfc543c8)  = -1 EINVAL (Invalid argument)

Hmm. That makes no sense.

I8K_BIOS_VERSION is 0x80046980 - and it already matches on both x86-64
and x86-32. I just checked by compiling to asm. And the size is '4',
so it wouldn't trigger any changes by the sizemask thing either.

Ugh. But my patch was crap. It fixed up "arg", but it *should* have
fixed up "cmd".

Stupid.

So try *this* one instead. I also fixed up the missing parenthesis,
but didn't add the actual .compat function etc.

Does *this* work? And if not, can you do an strace, but use the "-e
raw=ioctl" option to make it show the ioctl numbers as raw hex to
verify..

                     Linus

                        Linus

View attachment "patch.diff" of type "text/x-patch" (1908 bytes)