linux-kernel - Re: [RFC PATCH] usb, PCI: split quirk for usb host controller to three

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXPi2VY+cVOxaQr=MBy_m3Dr0BKG6DRTCP1TrbuDcMCfg@mail.gmail.com>
Date:	Thu, 1 Mar 2012 11:19:06 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-usb@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] usb, PCI: split quirk for usb host controller to three

On Thu, Mar 1, 2012 at 11:03 AM, Sarah Sharp
<sarah.a.sharp@...ux.intel.com> wrote:
> On Thu, Mar 01, 2012 at 09:24:35AM -0800, Greg Kroah-Hartman wrote:
>> On Thu, Mar 01, 2012 at 09:17:07AM -0800, Yinghai Lu wrote:
>> > so we avoid checking class again and again in that quirk.
>> >
>> > need to be applied after pci/linux-next and usb/usb-next
>>
>> As those are two independant trees, this needs to wait until after
>> 3.4-rc1 is out.
>>
>> > Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> >
>> > ---
>> >  drivers/usb/host/pci-quirks.c |   42 ++++++++++++++++++++++++++++--------------
>> >  1 file changed, 28 insertions(+), 14 deletions(-)
>>
>> Is this really helping anything here?  You added code overall :(
>
> I agree with Greg.  Why change this?  Does it shave off any boot time?
> Please show hard numbers for what improvements this makes.  I really
> don't want to change PCI init and break people's systems.

but your code make pci init change to call disable/enable for non-xhci
for fixing xhci problem.

| commit cab928ee1f221c9cc48d6615070fefe2e444384a
| Author: Sarah Sharp <sarah.a.sharp@...ux.intel.com>
| Date:   Tue Feb 7 15:11:46 2012 -0800
|
|    USB: Fix handoff when BIOS disables host PCI device.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/