linux-kernel - Re: [PATCH 6/9] fuse: Push file_update_time() into fuse_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87obsgce4a.fsf@tucsk.pomaz.szeredi.hu>
Date:	Thu, 01 Mar 2012 20:31:17 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Jan Kara <jack@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, dchinner@...hat.com,
	fuse-devel@...ts.sourceforge.net
Subject: Re: [PATCH 6/9] fuse: Push file_update_time() into fuse_page_mkwrite()

Jan Kara <jack@...e.cz> writes:

> CC: Miklos Szeredi <miklos@...redi.hu>
> CC: fuse-devel@...ts.sourceforge.net
> Signed-off-by: Jan Kara <jack@...e.cz>
> ---
>  fs/fuse/file.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 4a199fd..eade72e 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1323,6 +1323,7 @@ static int fuse_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
>  	 */
>  	struct inode *inode = vma->vm_file->f_mapping->host;
>  
> +	file_update_time(vma->vm_file);

Fuse sets S_CMTIME in inode flags, so this is a no-op.  IOW the patch is
not needed.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/