linux-kernel - Re: [PATCH] davinci_emac: fixed setting MAC at init time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120301.162837.1843924175078247309.davem@davemloft.net>
Date:	Thu, 01 Mar 2012 16:28:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	b.van.den.berg.nl@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, srk@...com,
	vinay.hegde@...com, cyril@...com, richard.cochran@...cron.at,
	Julia.Lawall@...6.fr, s.hauer@...gutronix.de, joe@...ches.com
Subject: Re: [PATCH] davinci_emac: fixed setting MAC at init time

From: Bas van den Berg <b.van.den.berg.nl@...il.com>
Date: Thu, 1 Mar 2012 09:42:42 +0100

> Without this patch, the MAC number will show up as zero's until the interface
> is brought up for the first time. (eg. with ifconfig -a)
> 
> Signed-off-by: Bas van den Berg <b.van.den.berg.nl@...il.com>

Well then the copy (which is also unnecessarily by hand using a loop
instead of a memcpy call) in emac_dev_open() is redundant and should
be removed when you make this change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/