[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1330569677-11984-1-git-send-email-ruan.zhengwang@gmail.com>
Date: Thu, 1 Mar 2012 10:41:17 +0800
From: Zhengwang Ruan <ruan.zhengwang@...il.com>
To: <rostedt@...dmis.org>, <fweisbec@...il.com>, <mingo@...hat.com>
CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: [PATCH v2] Trace: Add comment to notify a warning caused by a gcc bug
GCC (version < 4.6) warns 'page2' is uninitialized, but this is helpful
to track a real potential bug, simply add comment to note this.
Signed-off-by: Zhengwang Ruan <ruan.zhengwang@...il.com>
---
v2: Change fix to add a comment.
---
kernel/trace/trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a3f1bc5..ef332e6 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3694,7 +3694,7 @@ tracing_mark_write(struct file *filp, const char __user *ubuf,
int nr_pages = 1;
ssize_t written;
void *page1;
- void *page2;
+ void *page2; /* if you get a warning here, upgrade your gcc to 4.6 */
int offset;
int size;
int len;
--
1.6.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists