linux-kernel - Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F508908.4010907@nod.at>
Date:	Fri, 02 Mar 2012 09:47:04 +0100
From:	Richard Weinberger <richard@....at>
To:	Jonas Bonn <jonas@...thpole.se>
CC:	linux@...ts.openrisc.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

Am 02.03.2012 07:50, schrieb Jonas Bonn:
> On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
>> There is no need to reinvent the wheel.
> 
> NAK... we have optimized versions for some of these operations so the
> generic header isn't right for us.

Sorry, I missed that.

> Have a look at arch/openrisc/asm/include/bitops.h to see which functions
> we override with accelerated versions.

Okay, but some operations are missing in your bitopts.h.
Like test_bit_le() or find_next_zero_bit_le().

#include <asm-generic/bitops/le.h>
Should to the job...

Thanks,
//richard


Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)