linux-kernel - Re: [patch] dma-debug: debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120302125502.GW1003@mwanda>
Date:	Fri, 2 Mar 2012 15:55:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	Joerg Roedel <joerg.roedel@....com>,
	Stanislaw Gruszka <sgruszka@...hat.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] dma-debug: debugfs_create_bool() takes a u32 pointer

On Fri, Mar 02, 2012 at 06:22:03AM -0500, Neil Horman wrote:
> This certainly works, but a quick search of call sites shows this isn't the only
> place someone passes a bool to debugfs_create_bool. I think the better solution
> would be to change debugfs_create_bool and its corresponding read/write methods
> to actually work with a bool type, and then clean all the call sites to pass in
> a bool properly, instead of a u32.

There is only one other call site which gets this wrong, and I sent
a fix for that today as well.  But yes, you're probably right that
would be cleaner.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)