linux-kernel - Re: [PATCH] usb: gadgetfs: return number of bytes on ep0 read request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 02 Mar 2012 15:15:15 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Felipe Balbi" <balbi@...com>, linux-usb@...r.kernel.org,
	"Thomas Faber" <thfabba@....de>
Cc:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadgetfs: return number of bytes on ep0 read request

On Fri, 02 Mar 2012 09:41:50 +0100, Thomas Faber <thfabba@....de> wrote:
> A read from GadgetFS endpoint 0 during the data stage of a control
> request would always return 0 on success (as returned by
> wait_event_interruptible) despite having written data into the user
> buffer.
> This patch makes it correctly set the return value to the number of
> bytes read.
>
> Signed-off-by: Thomas Faber <thfabba@....de>

Acked-by: Michal Nazarewicz <mina86@...a86.com>
Cc: stable@...r.kernel.org

> ---
>  drivers/usb/gadget/inode.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
> index ae04266..4f18a0e 100644
> --- a/drivers/usb/gadget/inode.c
> +++ b/drivers/usb/gadget/inode.c
> @@ -1043,6 +1043,8 @@ ep0_read (struct file *fd, char __user *buf, size_t len, loff_t *ptr)
>  // FIXME don't call this with the spinlock held ...
>  				if (copy_to_user (buf, dev->req->buf, len))
>  					retval = -EFAULT;
> +				else
> +					retval = len;
>  				clean_req (dev->gadget->ep0, dev->req);
>  				/* NOTE userspace can't yet choose to stall */
>  			}


-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/