linux-kernel - Re: [PATCH 0/3] Replace bmp085 with bmp18x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201203021649.18156.arnd@arndb.de>
Date:	Fri, 2 Mar 2012 16:49:17 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Eric Andersson <eric.andersson@...xphere.com>,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	christoph.mair@...il.com, stefan.nilsson@...xphere.com,
	zhengguang.guo@...ch-sensortec.com, peter.moeller@...bosch.com,
	Jonathan Cameron <jic23@....ac.uk>
Subject: Re: [PATCH 0/3] Replace bmp085 with bmp18x

On Wednesday 29 February 2012, Alan Cox wrote:
> On Wed, 29 Feb 2012 20:18:45 +0000
> Arnd Bergmann <arnd@...db.de> wrote:
> 
> > On Wednesday 29 February 2012, Eric Andersson wrote:
> > > This patch-set replaces the BMP085 driver with a driver for Bosch Sensortec's new
> > > generation of pressure sensors called BMP18x. These pressure sensors can be
> > > connected on I2C but also on SPI as a variant, so the driver implements both.
> > > Register-wise they are fully compatible with the older BMP085, so the driver will
> > > support those chips as well.
> > > 
> > > The driver is based on bmp085.c by Christoph Mair.
> > 
> > Hmm,  the implementation looks fine, but I don't think we should add support
> > for new devices with a one-off interface that we know is getting replaced by
> > something generic.
> > 
> > Why is this not using IIO for its user interface?
> 
> This is become a repeating problem
> 
> Either get the IIO layer out of staging (where it appears to have
> congealed) or stop asking people to use it. IIO stuck in staging is
> becoming a problem not a cure. It's creating uncertainty blocking lots of
> stuff that needs to get upstream and that current stream is going to
> become a tide post Android merging.
> 
> It needs resolving one way or the other and soon.

Yes, that is probably true. It has been looking like we are closing in
on merging IIO for some time now, but I'm not sure how well it's going
recently. In November, Jonathan mentioned that he is busy with other
things and that he would welcome other people to help out. There were
patches to move parts of IIO out of staging, but I'm not completely
sure how far they have come.

In case of bmp085 I don't see much of a problem and I was probably
overreacting as this is an existing driver.

Unfortunately, I'm not sure if there is any reasonable alternative
to iio for new device drivers: If we get a flood of new drivers for
all sorts of sensors that each have their own user interface,
someone still needs to review all those interfaces and come up
with infrastucture to reduce the amount of code duplication and
interface differences between the drivers. IIO was promising to
do just that, and it has come a long way since it was initially
included into staging. 

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/