linux-kernel - Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F51114D.80704@zytor.com>
Date:	Fri, 02 Mar 2012 10:28:29 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Joshua C." <joshuacov@...glemail.com>
CC:	Bodo Eggert <7eggert@....de>, linux-kernel@...r.kernel.org
Subject: Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock

On 03/02/2012 09:53 AM, Joshua C. wrote:
> 
> I thought about your idea for separating the platform specific code in
> another file. It will make the code more modular but at the end we're
> talking about a single function that flips a single bit. I really
> don't see any real benefit from defining it in a separate file. It
> makes (from my point of view) reading the file just more difficult.
> That's why I decided to return the platform specific code back where
> it originally was and only modifiy the x86 code. So I can keep the
> changes at minimum. I'll post the patch later today and cc the tty
> maintainer. Thanks for the help and the ideas.
> 

Yeah, it seems a bit excessive in this case.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/