linux-kernel - Re: [PATCH 5/9] writeback: introduce the pageout work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120302115700.7d970497.akpm@linux-foundation.org>
Date:	Fri, 2 Mar 2012 11:57:00 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Jan Kara <jack@...e.cz>, Greg Thelen <gthelen@...gle.com>,
	Ying Han <yinghan@...gle.com>,
	"hannes@...xchg.org" <hannes@...xchg.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	Minchan Kim <minchan.kim@...il.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/9] writeback: introduce the pageout work

On Fri, 2 Mar 2012 18:39:51 +0800
Fengguang Wu <fengguang.wu@...el.com> wrote:

> > And I agree it's unlikely but given enough time and people, I
> > believe someone finds a way to (inadvertedly) trigger this.
> 
> Right. The pageout works could add lots more iput() to the flusher
> and turn some hidden statistical impossible bugs into real ones.
> 
> Fortunately the "flusher deadlocks itself" case is easy to detect and
> prevent as illustrated in another email.

It would be a heck of a lot safer and saner to avoid the iput().  We
know how to do this, so why not do it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/