linux-kernel - Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 02 Mar 2012 13:32:48 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Joshua C." <joshuacov@...glemail.com>
CC:	Bodo Eggert <7eggert@....de>, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock

On 03/02/2012 01:21 PM, Joshua C. wrote:
> 2012/3/2 H. Peter Anvin <hpa@...or.com>:
>>
>> Yeah, it seems a bit excessive in this case.
>>
>>        -hpa
>>
>> --
>> H. Peter Anvin, Intel Open Source Technology Center
>> I work for Intel.  I don't speak on their behalf.
>>
> 
> This is the final version. It works fine here on one laptop and a desktop.
> 
> @Alan
> Can you, please, queue this for the mainline and also push it to
> stable? The patch is straight forward and set the NumLock on a
> keyboard according to the data in the BIOS.
> 

I still prefer the inline function instead of a macro for KBD_DEFLEDS,
but this is in deep nitpick territory at this point, and the macro is
already there.

Reviewed-by: H. Peter Anvin <hpa@...or.com>


	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/