linux-kernel - Re: alpha: futex regression bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 03 Mar 2012 12:40:24 +1300
From:	Michael Cree <mcree@...on.net.nz>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Richard Henderson <rth@...ddle.net>,
	Michel Lespinasse <walken@...gle.com>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
	Matt Turner <mattst88@...il.com>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>
Subject: Re: alpha: futex regression bisected

On 03/03/12 11:36, Andrew Morton wrote:
> On Mon, 27 Feb 2012 19:48:28 +1300
> Michael Cree <mcree@...on.net.nz> wrote:
> 
>>> There is no 32-bit compare instruction.  These are implemented by
>>> consistently extending the values to a 64-bit type.  Since the
>>> load instruction sign-extends, we want to sign-extend the other
>>> quantity as well (despite the fact it's logically unsigned).
>>>
>>> So:
>>>
>>> -        :       "r"(uaddr), "r"((long)oldval), "r"(newval)
>>> +        :       "r"(uaddr), "r"((long)(int)oldval), "r"(newval)
>>>
>>> should do the trick.
>>
>> Thanks, that fixes it.  Will you formally submit a patch with commit
>> message or should I?
>>
>> You can have at least a Reviewed-by, or even an
>> Acked-by: Phil Carmody <ext-phil.2.carmody@...ia.com>
>> who correctly analysed the problem in response to when I suggested the
>> fix on the debian-alpha email list without explanation.
> 
> Seems that I am an alpha hacker!  This?
> 
> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: alpha: fix 32/64-bit bug in futex support

Thanks for attending to this!  Matt advises that he is still working on
getting his alpha-next queue back into action since the big kernel.org
hack so you picking it up is just the ticket.

Just to note that the futex fix fixes the glibc test suite failures and
the pulseaudio related crashes, but it does not fix the java compiiler
lockups that I was (and are still) observing. That is some other problem.

Cheers
Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/