linux-kernel - Re: [PATCH] i8k: fix ioctl handing (was Re: Linux 3.3-rc5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Mar 2012 19:25:46 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mark Lord <kernel@...savvy.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i8k: fix ioctl handing (was Re: Linux 3.3-rc5)

On Thu, Mar 1, 2012 at 7:26 AM, Mark Lord <kernel@...savvy.com> wrote:
>
> I'm still not 100% happy with the arg/argp passing to i8ki_unlocked_ioctl() though.
> Shouldn't there be a compat_ptr() macro in there someplace?

Yes, I think you should have "compat_ptr(arg)" there.

Patch looks good. And perhaps i8k_get_bios_version() should be renamed
to "i8k_get_smm_bios_version()" to not cause this crazy confusion
again.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/