| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Mar 2012 16:44:10 +0000 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Amit Daniel Kachhap <amit.kachhap@...aro.org> Cc: linux-pm@...ts.linux-foundation.org, linux-samsung-soc@...r.kernel.org, linaro-dev@...ts.linaro.org, patches@...aro.org, linux-kernel@...r.kernel.org, lm-sensors@...sensors.org, linux-acpi@...r.kernel.org Subject: Re: [linux-pm] [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote: > This movement is needed because the hwmon entries and corresponding > sysfs interface is a duplicate of utilities already provided by > driver/thermal/thermal_sys.c. The goal is to place it in mfd folder > and add necessary calls to get the temperature information. > --- a/Documentation/hwmon/exynos4_tmu > +++ /dev/null Moving this seems to be a failure, the device is exposing a hwmon interface even if you've moved the code to mfd (though it doesn't actually look like a multi-function device at all as far as I can see - usually a MFD would have a bunch of unrelated functionality while this has one function used by two subsystems). If anything it looks like the ADC driver ought to be moved into IIO with either generic or Exynos specific function drivers layered on top of it in hwmon and thermal making use of the values that are read. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists