linux-kernel - Re: [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 04 Mar 2012 05:59:00 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ravishankar N <cyberax82@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.

Namjae Jeon <linkinjeon@...il.com> writes:

>  Since '*outlen' is initialized to zero,it is currently possible to create a f ilename of length (FAT_LFN_LEN +1) when utf8 is not enabled.To enforce the FA T_LFN_LEN limit, we must perform one less iteration.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Signed-off-by: Ravishankar N <cyberax82@...il.com>
> ---
>  fs/fat/namei_vfat.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index aae3b4e..98ae804 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
>  		op = &outname[*outlen * sizeof(wchar_t)];
>  	} else {
>  		for (i = 0, ip = name, op = outname, *outlen = 0;
> -			 i < len && *outlen <= FAT_LFN_LEN;
> +			 i < len && *outlen < FAT_LFN_LEN;
>  			 *outlen += 1) {
>  			if (escape && (*ip == ':')) {
>  				if (i > len - 5)

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/