linux-kernel - Re: [linux-pm] [Patch] JBD and JBD2 missing set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201203042351.07405.rjw@sisk.pl>
Date:	Sun, 4 Mar 2012 23:51:07 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	linux-pm@...ts.linux-foundation.org
Cc:	Nigel Cunningham <nigel@...onice.net>, Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org
Subject: Re: [linux-pm] [Patch] JBD and JBD2 missing set_freezable()

On Friday, February 03, 2012, Nigel Cunningham wrote:
> Hi all.
> 
> With the latest and greatest changes to the freezer, I started seeing
> panics that were caused by jbd2 running post-process freezing and
> hitting the canary BUG_ON for non-TuxOnIce I/O submission. I've traced
> this back to a lack of set_freezable calls in both jbd and jbd2. Since
> they're clearly meant to be frozen (there are tests for freezing()), I
> submit the following patch to add the missing calls.
> 
> Signed-off-by: Nigel Cunningham <nigel@...onice.net>

Well, I wonder what the filesystems people think about that.

Thanks,
Rafael


> diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
> index 59c09f9..89cd985 100644
> --- a/fs/jbd/journal.c
> +++ b/fs/jbd/journal.c
> @@ -129,6 +129,8 @@ static int kjournald(void *arg)
>  	setup_timer(&journal->j_commit_timer, commit_timeout,
>  			(unsigned long)current);
> 
> +	set_freezable();
> +
>  	/* Record that the journal thread is running */
>  	journal->j_task = current;
>  	wake_up(&journal->j_wait_done_commit);
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index c0a5f9f..663e47c 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -139,6 +139,8 @@ static int kjournald2(void *arg)
>  	setup_timer(&journal->j_commit_timer, commit_timeout,
>  			(unsigned long)current);
> 
> +	set_freezable();
> +
>  	/* Record that the journal thread is running */
>  	journal->j_task = current;
>  	wake_up(&journal->j_wait_done_commit);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/