linux-kernel - Re: [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120304111211.GA22592@1984>
Date:	Sun, 4 Mar 2012 12:12:11 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Richard Weinberger <richard@....at>
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, eric.dumazet@...il.com,
	jengelh@...ozas.de, rostedt@...dmis.org
Subject: Re: [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG

On Fri, Mar 02, 2012 at 05:52:50PM +0100, Richard Weinberger wrote:
> Am 02.03.2012 17:49, schrieb Pablo Neira Ayuso:
> > On Thu, Mar 01, 2012 at 10:39:15PM +0100, Richard Weinberger wrote:
> >> Am 01.03.2012 12:27, schrieb Pablo Neira Ayuso:
> >>> While merging ipt_LOG and ip6t_LOG, you introduced some bug that
> >>> corrupts the log line. Note the extra PROTO=, I don't have any UDPLITE
> >>> traffic here.
> >>>
> >>> Looks like a missing break in one switch.
> >>
> >> I got confused by my own logic. :-\
> >> Does the attached patch fix the issue?
> >> It's based on "Netfilter: xt_LOG: Add timestamp support"
> > 
> > This patch lacks of description. If you don't make it myself, I have
> > to do it for you :-(
> > 
> > Please, send me patches following the standard format next time.
> 
> It was a "does this patch solve the problem"-Patch.
> Does it fix the problem?
> 
> If so, I'll send an official one...

Sorry, that's too much overhead. I don't mind testing it, but I want
to apply it as soon as it fixes the problem ;-)

It seems to fix the problem. I have added the description and will
push to my git tree. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/