linux-kernel - Re: [patch v2] edac i5000, i5400: fix pointer math in i5000_get_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Mar 2012 12:52:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	walter harms <wharms@....de>
Cc:	Eric Wollesen <ericw@...p.net>,
	Doug Thompson <dougthompson@...ssion.com>,
	list-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch v2] edac i5000, i5400: fix pointer math in
 i5000_get_mc_regs()

On Mon, Mar 05, 2012 at 10:45:39AM +0100, walter harms wrote:
> 
> 
> Am 05.03.2012 10:01, schrieb Dan Carpenter:
> > "pvt->ambase" is a u64 datatype.  The intent here is to fill the first
> > half in the first call to pci_read_config_dword() and the other half in
> > the second.  Unfortunately the pointer math is wrong so we set the wrong
> > data.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> > v2: Redid it as with a union as Walter Harms suggested.
> >     Fixed the same bug in i5400_edac.c as well.
> > 
> > I don't have this hardware, so please review carefully.
> > 
> > diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c
> > index 74d6ec34..083e80a 100644
> > --- a/drivers/edac/i5400_edac.c
> > +++ b/drivers/edac/i5400_edac.c
> > @@ -343,7 +343,13 @@ struct i5400_pvt {
> >  	struct pci_dev *branch_1;		/* 22.0 */
> >  
> >  	u16 tolm;				/* top of low memory */
> > -	u64 ambase;				/* AMB BAR */
> > +	union {
> > +		u64 ambase;				/* AMB BAR */
> > +		struct {
> > +			u32 ambase_bottom;
> > +			u32 ambase_top;
> > +		} u;
> > +	};
> >  
> 
> would this work with alignment=8 ?

Are you asking or telling?

I guess I'll add a __packed and resend in case it's an issue.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)