linux-kernel - Re: [RESEND] [PATCH] media: ir-sony-decoder: 15bit function decode fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F54AA3C.6010702@imgtec.com>
Date:	Mon, 5 Mar 2012 11:57:48 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	<linux-media@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND] [PATCH] media: ir-sony-decoder: 15bit function decode
 fix

Ping

Another week's gone by with no response. It's a trivial patch, so can
somebody please take a look at it? (or if I'm missing somebody relevant
from CC, please add them)

Thanks
James

On 27/02/12 11:53, James Hogan wrote:
> The raw Sony IR decoder decodes 15bit messages slightly incorrectly.
> To decode the function number, it shifts the bits right by 7 so that the
> function is in bits 7:1, masks with 0xFD (0b11111101), and does an 8 bit
> reverse so it ends up in bits 6:0. The mask should be 0xFE to correspond
> with bits 7:1 (0b11111110).
> 
> The old mask had the effect of dropping the MSB of the function number
> from bit 6, and leaving the LSB of the device number in bit 7.
> 
> Signed-off-by: James Hogan <james.hogan@...tec.com>
> ---
> 
> (note, i don't have a 15bit sony remote to test this with, but i'm
> pretty confident of it's correctness based on this:
> http://picprojects.org.uk/projects/sirc/sonysirc.pdf )
> 
>  drivers/media/rc/ir-sony-decoder.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/rc/ir-sony-decoder.c b/drivers/media/rc/ir-sony-decoder.c
> index d5e2b50..dab98b3 100644
> --- a/drivers/media/rc/ir-sony-decoder.c
> +++ b/drivers/media/rc/ir-sony-decoder.c
> @@ -130,7 +130,7 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev)
>  		case 15:
>  			device    = bitrev8((data->bits >>  0) & 0xFF);
>  			subdevice = 0;
> -			function  = bitrev8((data->bits >>  7) & 0xFD);
> +			function  = bitrev8((data->bits >>  7) & 0xFE);
>  			break;
>  		case 20:
>  			device    = bitrev8((data->bits >>  5) & 0xF8);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/