linux-kernel - Re: Build broken on s390 and ia64 [was: Linux 2.6.32.58]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F54B618.1090301@suse.cz>
Date:	Mon, 05 Mar 2012 13:48:24 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
CC:	Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, stable@...r.kernel.org, lwn@....net,
	Tony Luck <tony.luck@...el.com>,
	Jiri Slaby <jirislaby@...il.com>, raven@...maw.net
Subject: Re: Build broken on s390 and ia64 [was: Linux 2.6.32.58]

On 03/05/2012 01:02 PM, Heiko Carstens wrote:
> On Mon, Mar 05, 2012 at 12:32:58PM +0100, Jiri Slaby wrote:
>> Perhaps asm/compat.h should be included from linux/compat.h
>> unconditionally...
> 
> If you do that you need to add #ifdef wrappers around the is_compat_task()
> definitions in each arch that supports CONFIG_COMPAT. If that's all that's
> needed that would be great!

I don't know, I haven't checked. It was just a shot in the dark. Maybe
it's easier to revert the removal of asm/compat.h from s390 files. Could
you bake a patch?

>>> Linus Torvalds (2): Fix autofs compile without CONFIG_COMPAT
>>
>> But who defines is_compat_task *with* CONFIG_COMPAT on ia64?
>>
>> fs/autofs4/inode.c: In function 'autofs4_fill_super':
>> fs/autofs4/inode.c:345: error: implicit declaration of function
>> 'is_compat_task'
> 
> The ia64 compat code got entirely removed, since it was broken:
> 
> 32974ad4907cdde6c9de612cd1b2ee0568fb9409 "[IA64] Remove COMPAT_IA32 support"

Yes, but that is even in 2.6.34. So the fix for autofs is incomplete in
.32 as it breaks build on configs which used to work.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/