linux-kernel - Re: [PATCH 01/68] USB: cdc-acm, use tty_standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F54C7BD.1020105@suse.cz>
Date:	Mon, 05 Mar 2012 15:03:41 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Oliver Neukum <oliver@...kum.name>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 01/68] USB: cdc-acm, use tty_standard_install

Forgot to CC maintainers. Done now.

On 03/05/2012 02:51 PM, Jiri Slaby wrote:
> This is a piece I missed the last time.
> 
> Do not copy the functionality all over the tree. Instead, use the
> helper the tty layer provides us with.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> ---
>  drivers/usb/class/cdc-acm.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 6dcc3a3..b3fd449 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -509,17 +509,12 @@ static int acm_tty_install(struct tty_driver *driver, struct tty_struct *tty)
>  	if (!acm)
>  		return -ENODEV;
>  
> -	retval = tty_init_termios(tty);
> +	retval = tty_standard_install(driver, tty);
>  	if (retval)
>  		goto error_init_termios;
>  
>  	tty->driver_data = acm;
>  
> -	/* Final install (we use the default method) */
> -	tty_driver_kref_get(driver);
> -	tty->count++;
> -	driver->ttys[tty->index] = tty;
> -
>  	return 0;
>  
>  error_init_termios:


-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/